Convert textarea-rows-cols.html to dumpAsText()
Created attachment 47324 [details] Patch
Comment on attachment 47324 [details] Patch Looks good, but I feel the new test lacks information about scrollbar for the cols=1 case. It would be good to check if scrollHeight > defaultScrollHeight and scrollWidth < defaultScrollWidth ?
Created attachment 47387 [details] Proposed patch (rev.2)
(In reply to comment #2) > (From update of attachment 47324 [details]) > Looks good, but I feel the new test lacks information about scrollbar for the > cols=1 case. It would be good to check if scrollHeight > defaultScrollHeight > and scrollWidth < defaultScrollWidth ? Thank you for the comment. I added these checks.
Comment on attachment 47387 [details] Proposed patch (rev.2) Thanks for the fix! r+ assuming you'll address the comment below and combine patch v1 and v2 into a single patch. > -shouldBeTrue('defaultHeight > 0'); > -shouldBeTrue('defaultWidth > 0'); I guess we don't need to remove them?
(In reply to comment #5) > (From update of attachment 47387 [details]) > Thanks for the fix! r+ assuming you'll address the comment below and combine > patch v1 and v2 into a single patch. Wow, It seems I have missed --amend. I'll commit combined patch manually. > > -shouldBeTrue('defaultHeight > 0'); > > -shouldBeTrue('defaultWidth > 0'); > > I guess we don't need to remove them? Other assertions contain them implicitly. We may have them for readability, of course. I'll revive them.
Landed as r53844 <http://trac.webkit.org/changeset/53844>
Broken on windows: http://build.webkit.org/results/Windows%20Release%20(Tests)/r53896%20(8417)/fast/forms/textarea-rows-cols-diffs.txt
Looks like it's been broken for a while. I suspect this change.
(In reply to comment #9) > Looks like it's been broken for a while. I suspect this change. Yes, this happened due to my suggestion, sorry. It seems Windows Safari doesn't show scrollbars for this case. I think the reason of this difference is the size of fonts so we can just remove checks for scrollbars.
Created attachment 47536 [details] Go back to rev1
Created attachment 47537 [details] ChangeLog entry was wrong...
Comment on attachment 47537 [details] ChangeLog entry was wrong... ChangeLog looks wrong.
Created attachment 47875 [details] ChangeLog was wrong again
> ChangeLog looks wrong. Oops sorry.
Comment on attachment 47875 [details] ChangeLog was wrong again Looks good. r=me.
Committed r54201: <http://trac.webkit.org/changeset/54201>