Bug 3407 - accesskey doesn't work properly with <legend>
Summary: accesskey doesn't work properly with <legend>
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2005-06-10 00:18 PDT by Joost de Valk (AlthA)
Modified: 2005-06-20 08:59 PDT (History)
1 user (show)

See Also:

testcase (complete lay-out/accesskey test) (2.48 KB, text/html)
2005-06-10 00:59 PDT, Joost de Valk (AlthA)
no flags Details
Fix (6.62 KB, patch)
2005-06-11 05:24 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
A patch that actually applies (6.96 KB, patch)
2005-06-13 00:30 PDT, Anders Carlsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joost de Valk (AlthA) 2005-06-10 00:18:04 PDT
Apple radar bugs: 3481830, 3481843, 3481846
Comment 1 Joost de Valk (AlthA) 2005-06-10 00:59:06 PDT
Created attachment 2205 [details]
testcase (complete lay-out/accesskey test)

area and label seem to work, legend doesn't.
Comment 2 Anders Carlsson 2005-06-11 05:24:43 PDT
Created attachment 2246 [details]

Here's a patch that fixes accesskeys for legends. It also adds javascript focus
methods for legends and accesskeys.
Comment 3 Anders Carlsson 2005-06-13 00:30:30 PDT
Created attachment 2292 [details]
A patch that actually applies

Looks like the previous patch didn't apply at all. Here's a new one that should
Comment 4 Joost de Valk (AlthA) 2005-06-13 00:48:58 PDT
Patch (the second one) applies cleanly, and more important, works! Kudos to andersca for that :)
Comment 5 Darin Adler 2005-06-16 09:37:31 PDT
Comment on attachment 2292 [details]
A patch that actually applies

Patch looks good to me for coding style, although I don't know much about how
legends are supposed to work.
Comment 6 Anders Carlsson 2005-06-16 09:41:39 PDT
Focusing a legend should focus the first form element in the legend, that's what WinIE and Mozilla do.
Comment 7 Joost de Valk (AlthA) 2005-06-16 12:37:28 PDT
Yeah i agree with that. http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.11 is unclear as to 
what focussing a legend should do.
Comment 8 Darin Adler 2005-06-18 21:15:18 PDT
Changing the title to reflect that area and label seem to work already.
Comment 9 Darin Adler 2005-06-18 21:49:57 PDT
This patch fixes more than the bug marked here. This time I'm just going to make all the needed tests and 
land it, but next time I'll insist on using separate bug reports for separate fixes.
Comment 10 Chris Petersen 2005-06-18 23:09:04 PDT
Reporter, please mark this bug as Verified if this issue has been fixed in the latest TOT Webkit.
Comment 11 Joost de Valk (AlthA) 2005-06-19 23:05:34 PDT
Verified, and thx fot the hint Chris ;) Should this testcase be added to cvs btw?
Comment 12 Darin Adler 2005-06-20 08:59:36 PDT
We currently don't have a place for "manual" test cases, but when we do it would be good to put this one 
in there.

I created an automatic test case for this particular bug and landed it along with the bug fix in the layout-
tests directory.