Bug 34060 - check-webkit-style: Create a webkitpy/style/processors directory for the different processors
Summary: check-webkit-style: Create a webkitpy/style/processors directory for the diff...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-24 13:19 PST by Chris Jerdonek
Modified: 2010-01-26 18:56 PST (History)
5 users (show)

See Also:


Attachments
Proposed patch (596.23 KB, patch)
2010-01-26 07:34 PST, Chris Jerdonek
eric: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-01-24 13:19:42 PST
This will be a bit nicer for us as we--

(1) Add a shared processor file containing logic and checks common to multiple processors (e.g. the tab-check FIXME)
(1) Add a Python processor.
(3) Break checker.py into more than one file.

I will be doing (1) soon.

The file moves can go like this:

cpp_style.py -> processors/cpp.py
text_style.py -> processors/text.py

(and similarly for the associated unit test files)
Comment 1 Chris Jerdonek 2010-01-26 07:34:44 PST
Created attachment 47411 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2010-01-26 12:08:33 PST
Comment on attachment 47411 [details]
Proposed patch

Assuming all you're doing is moving code, looks OK to me.
Comment 3 Chris Jerdonek 2010-01-26 18:09:52 PST
Comment on attachment 47411 [details]
Proposed patch

Going to use webkit-patch.
Comment 4 Chris Jerdonek 2010-01-26 18:56:50 PST
(In reply to comment #3)
> (From update of attachment 47411 [details])
> Going to use webkit-patch.

Semi-automatically committed r53882 (via webkit-patch):

http://trac.webkit.org/changeset/53882

Encountered this bug in the process:

https://bugs.webkit.org/show_bug.cgi?id=34193