Bug 34031 - check-webkit-style: Remove the filename parameter from the style error handler functions
Summary: check-webkit-style: Remove the filename parameter from the style error handle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 19:08 PST by Chris Jerdonek
Modified: 2010-01-25 23:37 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (52.88 KB, patch)
2010-01-22 19:46 PST, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-01-22 19:08:16 PST
The filename parameter is unnecessary since it is the same for all errors processed within a file.  This refactoring will simplify the code a bit.
Comment 1 Chris Jerdonek 2010-01-22 19:46:46 PST
Created attachment 47262 [details]
Proposed patch
Comment 2 Chris Jerdonek 2010-01-22 19:51:14 PST
(In reply to comment #1)
> Created an attachment (id=47262) [details]
> Proposed patch

Just saw the size of this patch (53K).

FYI, I'd estimate that 85% of the size of this patch or so results from this simple search and replace: "error(filename, " -> "error(".
Comment 3 Shinichiro Hamaji 2010-01-25 20:56:56 PST
Comment on attachment 47262 [details]
Proposed patch

Sorry for the latency. I was a bit sick and busy these days.
Comment 4 Chris Jerdonek 2010-01-25 21:02:07 PST
(In reply to comment #3)
> (From update of attachment 47262 [details])
> Sorry for the latency. I was a bit sick and busy these days.

Thanks.  Hope you're feeling better...
Comment 5 Chris Jerdonek 2010-01-25 23:37:49 PST
Comment on attachment 47262 [details]
Proposed patch

Clearing flags on attachment: 47262

Committed r53841: <http://trac.webkit.org/changeset/53841>
Comment 6 Chris Jerdonek 2010-01-25 23:37:57 PST
All reviewed patches have been landed.  Closing bug.