All the logic for depending directly on V8<class>::GetTemplate() is in place for all but a couple classes (and those patches are in flight). Make GetTemplate() public. Also, while editing CodeGenetaorV8.pm, we should get rid of all the #includes of V8CustomBinding.h, since the generated bindings shouldn't need it any longer.
Created attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Looks good, thanks!
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Rejecting patch 47740 from review queue. japhet@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights.
I'll r+ this again once the commit-queue has been restarted :)
the commit-queue has been restarted and will now recognize nate as a reviewer.
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h r+ again then!
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Clearing flags on attachment: 47740 Committed r54179: <http://trac.webkit.org/changeset/54179>
All reviewed patches have been landed. Closing bug.