Bug 34025 - Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets
Summary: Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 15:24 PST by Steve Falkenburg
Modified: 2010-01-22 18:00 PST (History)
4 users (show)

See Also:


Attachments
patch (16.65 KB, patch)
2010-01-22 15:28 PST, Steve Falkenburg
no flags Details | Formatted Diff | Diff
updated patch (16.65 KB, patch)
2010-01-22 15:35 PST, Steve Falkenburg
no flags Details | Formatted Diff | Diff
re-post patch now that style queue is fixed (16.65 KB, patch)
2010-01-22 16:41 PST, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-01-22 15:24:26 PST
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
Comment 1 Steve Falkenburg 2010-01-22 15:28:12 PST
Created attachment 47236 [details]
patch
Comment 2 WebKit Review Bot 2010-01-22 15:31:56 PST
Attachment 47236 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 94, in <module>
    main()
  File "WebKitTools/Scripts/check-webkit-style", line 87, in main
    style_checker.check_patch(patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch
    self.check_file(file_path, handle_style_error=error_for_patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file
    process_file(processor, file_path, handle_style_error)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file
    processor.process(lines)
AttributeError: 'NoneType' object has no attribute 'process'


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2010-01-22 15:32:31 PST
Attachment 47236 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/207040
Comment 4 Eric Seidel (no email) 2010-01-22 15:32:45 PST
Attachment 47236 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/207042
Comment 5 Steve Falkenburg 2010-01-22 15:35:51 PST
Created attachment 47239 [details]
updated patch
Comment 6 WebKit Review Bot 2010-01-22 15:39:34 PST
Attachment 47239 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 94, in <module>
    main()
  File "WebKitTools/Scripts/check-webkit-style", line 87, in main
    style_checker.check_patch(patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch
    self.check_file(file_path, handle_style_error=error_for_patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file
    process_file(processor, file_path, handle_style_error)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file
    processor.process(lines)
AttributeError: 'NoneType' object has no attribute 'process'


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Eric Seidel (no email) 2010-01-22 15:43:32 PST
Attachment 47239 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/207053
Comment 8 Steve Falkenburg 2010-01-22 15:47:48 PST
Style bot and Mac bot failure seem to be problems with the tools (not the patch). Or, the output is malformed from the tools.
Comment 9 Adam Barth 2010-01-22 15:59:11 PST
(In reply to comment #8)
> Style bot and Mac bot failure seem to be problems with the tools (not the
> patch). Or, the output is malformed from the tools.

Just landed a fix for this in http://trac.webkit.org/changeset/53730
Comment 10 Steve Falkenburg 2010-01-22 16:41:09 PST
Created attachment 47244 [details]
re-post patch now that style queue is fixed
Comment 11 Steve Falkenburg 2010-01-22 18:00:08 PST
http://trac.webkit.org/changeset/53746