Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
Created attachment 47236 [details] patch
Attachment 47236 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 47236 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/207040
Attachment 47236 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/207042
Created attachment 47239 [details] updated patch
Attachment 47239 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 47239 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/207053
Style bot and Mac bot failure seem to be problems with the tools (not the patch). Or, the output is malformed from the tools.
(In reply to comment #8) > Style bot and Mac bot failure seem to be problems with the tools (not the > patch). Or, the output is malformed from the tools. Just landed a fix for this in http://trac.webkit.org/changeset/53730
Created attachment 47244 [details] re-post patch now that style queue is fixed
http://trac.webkit.org/changeset/53746