Bug 34009 - Don't go into compositing mode for 0x0 plugins
Summary: Don't go into compositing mode for 0x0 plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-01-22 11:07 PST by Simon Fraser (smfr)
Modified: 2010-07-12 17:42 PDT (History)
2 users (show)

See Also:


Attachments
WIP patch (2.69 KB, patch)
2010-07-07 22:53 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (29.01 KB, patch)
2010-07-12 17:00 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-01-22 11:07:22 PST
Followup from bug 33821: there's no point in going into compositing mode for a 0x0 plugin
Comment 1 mitz 2010-05-03 12:54:48 PDT
<rdar://problem/7935757>
Comment 2 Simon Fraser (smfr) 2010-07-06 16:54:34 PDT
This isn't as simple as it would appear to be, because we can't look at the renderer size from updateStyle() (where we make compositing decisions), because layout hasn't happened yet.
Comment 3 Simon Fraser (smfr) 2010-07-07 22:53:45 PDT
Created attachment 60843 [details]
WIP patch
Comment 4 Simon Fraser (smfr) 2010-07-11 11:27:45 PDT
Sites to test:
gmail.com
Mobile Me "Find my iPhone"
yahoo mail
Comment 5 Simon Fraser (smfr) 2010-07-12 17:00:00 PDT
Created attachment 61294 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-07-12 17:38:57 PDT
I filed bug 42120 to optimize m_compositingDependsOnGeometry.
Comment 7 Simon Fraser (smfr) 2010-07-12 17:42:10 PDT
http://trac.webkit.org/changeset/63149