Bug 34007 – Implement hardware acceleration of video on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Update the Windows QuickTime media engine to use hardware accelerated compositing.

[Eric Carlson]

<rdar://problem/7373568>

[Eric Carlson]

Created attachment 47217 [details]
Proposed patch

[Adam Roben (:aroben)]

Comment on attachment 47217 [details]
Proposed patch

> +        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the 
> +            movie is not ready to render or the movie is in a media document.

This isn't true anymore.

> @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause()
>          return;
>      m_startedPlaying = false;
>  #if DRAW_FRAME_RATE
> -    m_timeStoppedPlaying = GetTickCount();
> +    m_timeStoppedPlaying = WTF::currentTime();

You shouldn't need the "WTF::" here.

r=me

[Eric Carlson]

(In reply to comment #3)
> (From update of attachment 47217 [details])
> > +        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the 
> > +            movie is not ready to render or the movie is in a media document.
> 
> This isn't true anymore.
> 
  True.

> > @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause()
> >          return;
> >      m_startedPlaying = false;
> >  #if DRAW_FRAME_RATE
> > -    m_timeStoppedPlaying = GetTickCount();
> > +    m_timeStoppedPlaying = WTF::currentTime();
> 
> You shouldn't need the "WTF::" here.
> 
  MediaPlayerPrivate has a "currentTime" method.

> r=me

  Thanks!

[Eric Carlson]

http://trac.webkit.org/changeset/53711

[Eric Carlson]

With http://trac.webkit.org/changeset/53725 for good measure.