Bug 34007 - Implement hardware acceleration of video on Windows
Summary: Implement hardware acceleration of video on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-01-22 10:14 PST by Eric Carlson
Modified: 2010-01-22 15:50 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (22.62 KB, patch)
2010-01-22 12:06 PST, Eric Carlson
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-01-22 10:14:27 PST
Update the Windows QuickTime media engine to use hardware accelerated compositing.
Comment 1 Eric Carlson 2010-01-22 12:03:37 PST
<rdar://problem/7373568>
Comment 2 Eric Carlson 2010-01-22 12:06:49 PST
Created attachment 47217 [details]
Proposed patch
Comment 3 Adam Roben (:aroben) 2010-01-22 12:21:54 PST
Comment on attachment 47217 [details]
Proposed patch

> +        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the 
> +            movie is not ready to render or the movie is in a media document.

This isn't true anymore.

> @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause()
>          return;
>      m_startedPlaying = false;
>  #if DRAW_FRAME_RATE
> -    m_timeStoppedPlaying = GetTickCount();
> +    m_timeStoppedPlaying = WTF::currentTime();

You shouldn't need the "WTF::" here.

r=me
Comment 4 Eric Carlson 2010-01-22 12:46:19 PST
(In reply to comment #3)
> (From update of attachment 47217 [details])
> > +        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the 
> > +            movie is not ready to render or the movie is in a media document.
> 
> This isn't true anymore.
> 
  True.

> > @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause()
> >          return;
> >      m_startedPlaying = false;
> >  #if DRAW_FRAME_RATE
> > -    m_timeStoppedPlaying = GetTickCount();
> > +    m_timeStoppedPlaying = WTF::currentTime();
> 
> You shouldn't need the "WTF::" here.
> 
  MediaPlayerPrivate has a "currentTime" method.

> r=me

  Thanks!
Comment 5 Eric Carlson 2010-01-22 12:46:36 PST
http://trac.webkit.org/changeset/53711
Comment 6 Eric Carlson 2010-01-22 15:50:42 PST
With http://trac.webkit.org/changeset/53725 for good measure.