Bug 34006 - svg/custom/text-zoom.xhtml fails on Windows
Summary: svg/custom/text-zoom.xhtml fails on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Windo...
Keywords: InRadar, LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-01-22 09:31 PST by Adam Roben (:aroben)
Modified: 2010-01-23 17:51 PST (History)
1 user (show)

See Also:

Attachments
Set the default value for WebKitZoomsTextOnlyPreferenceKey to true (3.37 KB, patch)
2010-01-23 17:32 PST, mitz 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-01-22 09:31:24 PST 
svg/custom/text-zoom.xhtml fails on Windows. See <http://build.webkit.org/results/Windows%20Release%20(Tests)/r53703%20(8266)/svg/custom/text-zoom-pretty-diff.html> for the diff produced by the test.

It looks like the green rectangle is getting zoomed when it shouldn't.
Comment 1 Adam Roben (:aroben) 2010-01-22 09:31:52 PST 
<rdar://problem/7569820>
Comment 2 Adam Roben (:aroben) 2010-01-22 09:33:01 PST 
The test fails in Safari as well:

If I check "Zoom Text Only" in the View menu, then zoom, the rectangle zooms and I do see red.

The same thing happens if I uncheck "Zoom Text Only".
Comment 3 Adam Roben (:aroben) 2010-01-22 09:43:51 PST 
(In reply to comment #2)
> The test fails in Safari as well:
> 
> If I check "Zoom Text Only" in the View menu, then zoom, the rectangle zooms
> and I do see red.
> 
> The same thing happens if I uncheck "Zoom Text Only".

I was testing with r53683. With r53686 the test passes in Safari, but still fails in DRT.
Comment 4 Adam Roben (:aroben) 2010-01-22 10:33:27 PST 
Expected failure results for this test were checked in in r53704, so this test now appears to pass on Windows, but the results are incorrect.
Comment 5 mitz 2010-01-22 12:53:49 PST 
The problem is that WebPreferences::initializeDefaultSettings() fails to set the default value of WebKitZoomsTextOnlyPreferenceKey to true.
Comment 6 mitz 2010-01-23 17:32:16 PST 
Created attachment 47284 [details]
Set the default value for WebKitZoomsTextOnlyPreferenceKey to true
Comment 7 Maciej Stachowiak 2010-01-23 17:45:28 PST 
Comment on attachment 47284 [details]
Set the default value for WebKitZoomsTextOnlyPreferenceKey to true

r=me
Comment 8 mitz 2010-01-23 17:51:44 PST 
Fixed in <http://trac.webkit.org/projects/webkit/changeset/53773>.