Reproduction: 1. Edit WebCore/WebCoreSources.bkl 2. Run check-webkit-style The result after r53675: Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' This is because dispatcher.dispatch_processor returns None for file_type value FileType.NONE
Created attachment 47199 [details] Quick fix by not calling process_file if the processor is None.
Attachment 47199 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 47200 [details] Quick fix by not calling process_file if the processor is None. (fixed) Oops, that was embarassing. Fixed.
Comment on attachment 47200 [details] Quick fix by not calling process_file if the processor is None. (fixed) Clearing flags on attachment: 47200 Committed r53730: <http://trac.webkit.org/changeset/53730>
All reviewed patches have been landed. Closing bug.