Bug 33977 – [Chromium] WebNode::toElement refcounts incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

The following results in the refcount on 'foo' decreasing by one, when it should stay the same:

{
  WebNode n = foo;
  WebElement e = n.toElement<WebElement>();
}

This is because WebNode::toElement() does not increment the refcount on 'foo', but the WebElement destructor does decrement the refcount.

[James Robinson]

Created attachment 47155 [details]
Fixes the bug by using WebNode::assign()

I have to use the WebNode:: qualifier because some T's that are used in this function (like WebElement) define incompatible 1-arg versions of ::assign(), for example WebElement::assign(const WebElement& e).  This confuses visual studio terribly.  I'm not sure if this is an issue with the compiler, but we always want to use the WebNode::assign() version anyway.

[WebKit Commit Bot]

Comment on attachment 47155 [details]
Fixes the bug by using WebNode::assign()

Clearing flags on attachment: 47155

Committed r53678: <http://trac.webkit.org/changeset/53678>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.