WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 33969
Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
https://bugs.webkit.org/show_bug.cgi?id=33969
Summary
Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
Darin Fisher (:fishd, Google)
Reported
2010-01-21 13:19:15 PST
Unnecessary call to HistoryItem::targetItem in HistoryController::pushState createTreeItem is called with m_frame, and createTreeItem sets isTargetItem to true if the Frame passed to it is equal to m_frame. so calling targetItem on the result returned from createTreeItem(m_frame,...) is unnecessary.
Attachments
v1 patch
(1.60 KB, patch)
2010-01-21 13:21 PST
,
Darin Fisher (:fishd, Google)
levin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1
2010-01-21 13:21:53 PST
Created
attachment 47142
[details]
v1 patch
Darin Fisher (:fishd, Google)
Comment 2
2010-01-21 14:25:33 PST
Landed as
http://trac.webkit.org/changeset/53650
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug