Bug 33969 - Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
Summary: Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 13:19 PST by Darin Fisher (:fishd, Google)
Modified: 2010-01-21 14:25 PST (History)
1 user (show)

See Also:


Attachments
v1 patch (1.60 KB, patch)
2010-01-21 13:21 PST, Darin Fisher (:fishd, Google)
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-01-21 13:19:15 PST
Unnecessary call to HistoryItem::targetItem in HistoryController::pushState

createTreeItem is called with m_frame, and createTreeItem sets isTargetItem to true
if the Frame passed to it is equal to m_frame.  so calling targetItem on the result
returned from createTreeItem(m_frame,...) is unnecessary.
Comment 1 Darin Fisher (:fishd, Google) 2010-01-21 13:21:53 PST
Created attachment 47142 [details]
v1 patch
Comment 2 Darin Fisher (:fishd, Google) 2010-01-21 14:25:33 PST
Landed as http://trac.webkit.org/changeset/53650