Bug 33968 – Canvas: Exception erroneously thrown for drawImage() when image.complete=false

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kai Hendry]

Just tried http://roulette.dabase.com/ on r53596 and it also fails to render, while Gecko and Presto can.

I can work around on this problem by adding a timeout. There is some bizaare DOM ready bug I guess.

[Andreas Kling]

Both the site and WebKit are at fault here.

The page is using $(document).ready() instead of $(window).load() - $d(document).ready() fires as soon as the DOM is ready instead of waiting for subresources (images in this case) to finish loading.

However, since the image element passed to drawImage() has complete=false, nothing should be done (HTML5 4.8.11), so the exception is thrown in error.

Patch coming in a moment.

[Andreas Kling]

Created attachment 60021 [details]
Proposed patch

Implement correct behavior for drawImage() with incomplete image or video. Autotest included.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

[Andreas Kling]

For future visitors to this bug, the page at http://roulette.dabase.com/ has now been updated to use $(window).load() :-)

[WebKit Commit Bot]

Comment on attachment 60021 [details]
Proposed patch

Clearing flags on attachment: 60021

Committed r62273: <http://trac.webkit.org/changeset/62273>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.