Bug 33955 - webkit-patch should retry on invalid password
Summary: webkit-patch should retry on invalid password
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 08:23 PST by Joe Mason
Modified: 2010-01-22 16:12 PST (History)
2 users (show)

See Also:


Attachments
put bugzilla login in a loop (3.03 KB, patch)
2010-01-21 08:23 PST, Joe Mason
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2010-01-21 08:23:09 PST
Created attachment 47120 [details]
put bugzilla login in a loop

Making a typo in your password and having to restart the whole process is really annoying.  webkit-patch should ask for credentials in a loop so that it automatically asks again on failure.  (The user can always use Ctrl-C to break out.)
Comment 1 Adam Barth 2010-01-21 10:02:04 PST
Comment on attachment 47120 [details]
put bugzilla login in a loop

In general we prefer to add unit tests when changing code in webkitpy, but bugzilla.py is difficult to test currently.

Thanks for the patch.
Comment 2 Adam Barth 2010-01-22 16:12:22 PST
Committed r53733: <http://trac.webkit.org/changeset/53733>