RESOLVED FIXED 33953
[Android] Android lacks V8 equivalent of JavaStringJSC.h 
https://bugs.webkit.org/show_bug.cgi?id=33953
Summary [Android] Android lacks V8 equivalent of JavaStringJSC.h
Steve Block
Reported 2010-01-21 08:15:37 PST
The JSC-specific implementation of JavaString was moved to JavaStringJSC.h in http://trac.webkit.org/changeset/53449 Android requires a V8 implementation of JavaString
Attachments
Patch (3.63 KB, patch)
2010-01-29 03:35 PST, Steve Block 		ariya.hidayat: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-01-29 03:35:54 PST
Created attachment 47698 [details] Patch
Ariya Hidayat
Comment 2 2010-01-31 15:57:06 PST
Comment on attachment 47698 [details] Patch > + const char* cs = getCharactersFromJStringInEnv(e, s); > + { > + m_utf8String = WebCore::CString(cs, size); > + } Minor nitpick: since we don't need JSLock here, do we need to put that line in its own block? Otherwise, LGTM.
Steve Block
Comment 3 2010-02-01 02:52:10 PST
> Minor nitpick: since we don't need JSLock here, do we need to put that line in > its own block? Fixed Landed manually as http://trac.webkit.org/changeset/54132 Closing bug as resolved fixed.
Note You need to log in before you can comment on or make changes to this bug.