Bug 33953 - [Android] Android lacks V8 equivalent of JavaStringJSC.h
Summary: [Android] Android lacks V8 equivalent of JavaStringJSC.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32154
  Show dependency tree / graph
 
Reported: 2010-01-21 08:15 PST by Steve Block
Modified: 2010-02-01 02:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2010-01-29 03:35 PST, Steve Block 		ariya.hidayat: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-21 08:15:37 PST 
The JSC-specific implementation of JavaString was moved to JavaStringJSC.h in
http://trac.webkit.org/changeset/53449

Android requires a V8 implementation of JavaString
Comment 1 Steve Block 2010-01-29 03:35:54 PST 
Created attachment 47698 [details]
Patch
Comment 2 Ariya Hidayat 2010-01-31 15:57:06 PST 
Comment on attachment 47698 [details]
Patch


> +        const char* cs = getCharactersFromJStringInEnv(e, s);
> +        {
> +            m_utf8String = WebCore::CString(cs, size);
> +        }

Minor nitpick: since we don't need JSLock here, do we need to put that line in its own block?

Otherwise, LGTM.
Comment 3 Steve Block 2010-02-01 02:52:10 PST 
> Minor nitpick: since we don't need JSLock here, do we need to put that line in
> its own block?
Fixed

Landed manually as http://trac.webkit.org/changeset/54132

Closing bug as resolved fixed.