Bug 33951 - [Android] Android lacks V8 equivalent of JavaInstanceJSC
Summary: [Android] Android lacks V8 equivalent of JavaInstanceJSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 32154
  Show dependency tree / graph
 
Reported: 2010-01-21 07:45 PST by Steve Block
Modified: 2018-09-16 17:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.93 KB, patch)
2010-01-29 04:23 PST, Steve Block 		ariya.hidayat: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-21 07:45:01 PST 
The JSC-specific version of JavaInstance was moved to JavaInstanceJSC in
http://trac.webkit.org/changeset/53412

Android requires a V8 version of JavaInstance
Comment 1 Steve Block 2010-01-29 04:23:06 PST 
Created attachment 47704 [details]
Patch
Comment 2 Ariya Hidayat 2010-02-01 11:19:31 PST 
Comment on attachment 47704 [details]
Patch

> +    // Try to find a good match for the overloaded method.  The
> +    // fundamental problem is that JavaScript doesn have the

Typo: doesn (actually also in JavaInstanceJSC.cpp).

Also, compared to others V8 JavaFoo version, this one very closely resembles JavaInstanceJSC.cpp, so IMO the original copyright should be kept.

Otherwise, LGTM.
Comment 3 Steve Block 2010-02-01 16:05:06 PST 
> Typo: doesn (actually also in JavaInstanceJSC.cpp).
Fixed in both files

> Also, compared to others V8 JavaFoo version, this one very closely resembles
> JavaInstanceJSC.cpp, so IMO the original copyright should be kept.
Fixed

Landed manually as http://trac.webkit.org/changeset/54165

Closing bug as resolved fixed.
Comment 4 wubibu 2018-09-16 17:29:25 PDT 
I face the same issue while install and try to run the Clash of clans private servers. I think Android lacks V8 issue occurs while I try to play the COC servers game. Please tell me the fix as soon as possible.

https://clashprivateservers.com/