Bug 33942 - 3 tests for CSS are misplaced
Summary: 3 tests for CSS are misplaced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 01:24 PST by Shinichiro Hamaji
Modified: 2010-01-21 18:37 PST (History)
0 users

See Also:


Attachments
Patch (165.06 KB, patch)
2010-01-21 01:29 PST, Shinichiro Hamaji
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-01-21 01:24:10 PST
The following 3 tests are in LayoutTests/css2.1.

atrule_longest_match.html
bogus-color-span.html
css1_forward_compatible_parsing.html

As this directory should be the copy of CSS2.1 testsuite, these files should be moved to another directory (probably LayoutTests/fast/css).
Comment 1 Shinichiro Hamaji 2010-01-21 01:29:23 PST
Created attachment 47106 [details]
Patch
Comment 2 Darin Adler 2010-01-21 09:27:31 PST
Comment on attachment 47106 [details]
Patch

r=me

To make the hierarchy of LayoutTests more self explanatory we might want to add files to various directories to help explain their contents.

They could be named README.txt or some other sensible name. Then the one for css2.1 could explain what that directory is.

I think that would be even better than having external documentation about LayoutTests.
Comment 3 Shinichiro Hamaji 2010-01-21 17:42:27 PST
Committed r53664: <http://trac.webkit.org/changeset/53664>
Comment 4 Shinichiro Hamaji 2010-01-21 18:37:15 PST
> To make the hierarchy of LayoutTests more self explanatory we might want to add
> files to various directories to help explain their contents.
> 
> They could be named README.txt or some other sensible name. Then the one for
> css2.1 could explain what that directory is.
> 
> I think that would be even better than having external documentation about
> LayoutTests.

I really like this idea. I'm adding the first version of README.txt in the patch for Bug 17557.