Bug 33935 - Use xmlStrdup instead of strdup for consistency in Libxml2.
Summary: Use xmlStrdup instead of strdup for consistency in Libxml2.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-20 18:51 PST by Kwang Yul Seo
Modified: 2019-02-06 09:03 PST (History)
3 users (show)

See Also:

Attachments
Use xmlStrdup instead of strdup in Libxml2 (2.54 KB, patch)
2010-01-20 18:57 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-01-20 18:51:48 PST 
Use xmlStrdup instead of strdup for consistency. This is the first step to remove the direct use of strdup from WebKit.

reinterpret_cast is required convert between xmlChar* and char* because xmlChar is typedef to unsigned char.
Comment 1 Kwang Yul Seo 2010-01-20 18:57:58 PST 
Created attachment 47091 [details]
Use xmlStrdup instead of strdup in Libxml2
Comment 2 Alexey Proskuryakov 2010-01-20 21:03:24 PST 
Comment on attachment 47091 [details]
Use xmlStrdup instead of strdup in Libxml2

r=me
Comment 3 WebKit Commit Bot 2010-01-20 21:58:35 PST 
Comment on attachment 47091 [details]
Use xmlStrdup instead of strdup in Libxml2

Clearing flags on attachment: 47091

Committed r53604: <http://trac.webkit.org/changeset/53604>
Comment 4 WebKit Commit Bot 2010-01-20 21:58:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Lucas Forschler 2019-02-06 09:03:25 PST 
Mass moving XML DOM bugs to the "DOM" Component.