Bug 33932 - [Chromium] Implement texSubImage2D taking WebGLArray
Summary: [Chromium] Implement texSubImage2D taking WebGLArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-20 18:27 PST by Kenneth Russell
Modified: 2010-01-21 23:26 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.66 KB, patch)
2010-01-20 18:34 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-01-20 18:27:30 PST
It seems that the texSubImage2D variant taking a WebGLArray as argument was not implemented in either https://bugs.webkit.org/show_bug.cgi?id=31562 or https://bugs.webkit.org/show_bug.cgi?id=33241 . This needs to be done.
Comment 1 Kenneth Russell 2010-01-20 18:34:32 PST
Created attachment 47090 [details]
Patch

Chromium-specific issue, but test case verified on WebKit as well.
Comment 2 Oliver Hunt 2010-01-20 18:40:14 PST
Comment on attachment 47090 [details]
Patch

r=me
Comment 3 Oliver Hunt 2010-01-20 19:04:45 PST
ken do you have commit bit yet?
Comment 4 Kenneth Russell 2010-01-21 10:05:18 PST
(In reply to comment #3)
> ken do you have commit bit yet?

Yes; I was waiting to see whether the bots would all clear the patch but it looks like a few are offline. Just cq+'d it.
Comment 5 WebKit Commit Bot 2010-01-21 13:01:47 PST
Comment on attachment 47090 [details]
Patch

Clearing flags on attachment: 47090

Committed r53640: <http://trac.webkit.org/changeset/53640>
Comment 6 WebKit Commit Bot 2010-01-21 13:02:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2010-01-21 23:26:27 PST
> Yes; I was waiting to see whether the bots would all clear the patch but it
> looks like a few are offline. Just cq+'d it.

The bots only run on patches that have review?.  Once you r+ a patch, the bots ignore it.