Bug 33928 – Add support for touch manipulation events

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Petri Latvala]

Add support for manipulation events which carry the manipulation information (pan, rotation and scale) from a performed touch gesture.

[Petri Latvala]

Created attachment 47081 [details]
Manipulate events implemented

Manipulation events implemented with a basic layout test. The test does not test manipulation speeds (panSpeedX, scaleSpeed etc), because that requires changes to eventSender.leapForward(), which currently only works for mouse events.

[Petri Latvala]

Created attachment 47088 [details]
Manipulate events implementation, rebased

Rebased the patch to a more current upstream version so it applied.

[WebKit Review Bot]

Attachment 47088 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/203497

[WebKit Review Bot]

Attachment 47088 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/204473

[Petri Latvala]

Created attachment 47193 [details]
Manipulate events implementation, rebased again

Rebased the patch again so it doesn't apply wrong.

[WebKit Review Bot]

Attachment 47193 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Traceback (most recent call last):
  File "WebKitTools/Scripts/check-webkit-style", line 94, in <module>
    main()
  File "WebKitTools/Scripts/check-webkit-style", line 87, in main
    style_checker.check_patch(patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch
    self.check_file(file_path, handle_style_error=error_for_patch)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file
    process_file(processor, file_path, handle_style_error)
  File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file
    processor.process(lines)
AttributeError: 'NoneType' object has no attribute 'process'


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Hausmann]

My feeling is that unlike with the touch events that are more of a defacto standard, for these gesture APIs - which look very nice btw - we should go through a standardization process first.

I suggest to publish a spec draft on w3.org first and then implement it with this patch as reference implementation.

[WebKit Review Bot]

Attachment 47193 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/204755

[Simon Hausmann]

Comment on attachment 47193 [details]
Manipulate events implementation, rebased again

Taking this patch out of the review queue as we discussed on the phone this morning that this needs some standardization and discussion via www-dom.