Bug 33918 - MSAA: accSelect() is not implemented
Summary: MSAA: accSelect() is not implemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar
: 29124 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-20 13:19 PST by Jon Honeycutt
Modified: 2011-03-31 16:27 PDT (History)
1 user (show)

See Also:

Attachments
patch (23.82 KB, patch)
2010-01-20 13:30 PST, Jon Honeycutt 		darin: review+
jhoneycutt: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2010-01-20 13:19:34 PST 
The IAccessible::accSelect() function is not implemented.

<rdar://problem/7436861>
Comment 1 Jon Honeycutt 2010-01-20 13:30:57 PST 
Created attachment 47060 [details]
patch
Comment 2 Darin Adler 2010-01-20 14:10:56 PST 
Comment on attachment 47060 [details]
patch

> +    // FIXME: Should implement SELFLAG_EXTENDSELECTION. For now, we just return
> +    // S_OK, matching Firefox.

Is that really better than returning E_INVALIDARG?
Comment 3 Jon Honeycutt 2010-01-20 14:33:22 PST 
(In reply to comment #2)
> (From update of attachment 47060 [details])
> > +    // FIXME: Should implement SELFLAG_EXTENDSELECTION. For now, we just return
> > +    // S_OK, matching Firefox.
> 
> Is that really better than returning E_INVALIDARG?

I'm not sure whether any clients use this flag, but I'd rather match Firefox's behavior.

Thanks for the review! Landed in r53567.
Comment 4 Jon Honeycutt 2011-03-31 16:27:50 PDT 
*** Bug 29124 has been marked as a duplicate of this bug. ***