Bug 33916 – openDatabase should throw exception if database access is disallowed

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Eric U.]

From the spec [http://dev.w3.org/html5/webdatabase/ section 4.1.1]: "The user agent may raise a SECURITY_ERR exception instead of returning a Database object if the request violates a policy decision (e.g. if the user agent is configured to not allow the page to open databases)."  We're just returning null, which isn't an option offered by the specification.

The current behavior is enforced by LayoutTests/fast/frames/sandboxed-iframe-storage.html.

[Dumitru Daniliuc]

Created attachment 52889 [details]
patch

[Dimitri Glazkov (Google)]

Comment on attachment 52889 [details]
patch

ok. Can you reference a layout test that enforces it?

[Patrik Persson]

(In reply to comment #3)
> From the spec [http://dev.w3.org/html5/webdatabase/ section 4.1.1]: "The user
> agent may raise a SECURITY_ERR exception instead of returning a Database object
> if the request violates a policy decision (e.g. if the user agent is configured
> to not allow the page to open databases)."  We're just returning null, which
> isn't an option offered by the specification.
> 
> The current behavior is enforced by
> LayoutTests/fast/frames/sandboxed-iframe-storage.html.

FYI: that particular layout test was revised in bug 32369. However, that change was specific to sandboxed iframes. Other database policy decisions were not addressed by bug 32369.

[Dumitru Daniliuc]

Do we have a way to turn on/off DB support in tests? If not, then I'm not sure how to write a test for this patch, because DB support is enabled by default.

[Dumitru Daniliuc]

Landed as r57492.

[WebKit Review Bot]

http://trac.webkit.org/changeset/57492 might have broken SnowLeopard Intel Release (Tests)

[Dumitru Daniliuc]

(In reply to comment #6)
> http://trac.webkit.org/changeset/57492 might have broken SnowLeopard Intel
> Release (Tests)

Fixed storage/open-database-over-quota.html in r57493.