Bug 33908 - [Chromium] Skia "seatbelts" should be removed.
Summary: [Chromium] Skia "seatbelts" should be removed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-20 09:41 PST by Stephen White
Modified: 2010-01-20 20:54 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2010-01-20 09:45 PST, Stephen White
no flags Details | Formatted Diff | Diff
Patch (1.59 KB, patch)
2010-01-20 10:00 PST, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-01-20 09:41:58 PST
[Chromium] Skia "seatbelts" should be removed.
Comment 1 Stephen White 2010-01-20 09:45:12 PST
Created attachment 47042 [details]
Patch
Comment 2 Stephen White 2010-01-20 09:49:31 PST
ENSURE_VALUE_SAFETY_FOR_SKIA should be disabled, since we believe we've fixed the underlying Skia problems, and the seatbelts themselves also causing bugs (e.g., http://crbug.com/18630).
Comment 3 David Levin 2010-01-20 09:54:45 PST
Comment on attachment 47042 [details]
Patch

> Index: WebCore/ChangeLog
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Disable the "seatbelt" coordinate validation functions in the
> +        Skia graphics layer.  We believe all the underlying bugs have
> +        been fixed, but just in case we're being overly optimistic, this
> +        leaves in the code for an easy revert.

Please add a bug link here.


> Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
> +// Diabling these checks (20/01/2010), since we think we've fixed all the Skia

typo: Diabling
Comment 4 Stephen White 2010-01-20 10:00:37 PST
Created attachment 47044 [details]
Patch
Comment 5 WebKit Commit Bot 2010-01-20 20:54:54 PST
Comment on attachment 47044 [details]
Patch

Clearing flags on attachment: 47044

Committed r53600: <http://trac.webkit.org/changeset/53600>
Comment 6 WebKit Commit Bot 2010-01-20 20:54:59 PST
All reviewed patches have been landed.  Closing bug.