Bug 33904 - Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
Summary: Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-01-20 08:28 PST by Pavel Feldman
Modified: 2010-01-25 03:01 PST (History)
4 users (show)

See Also:

[PATCH] Proposed change. (20.86 KB, patch)
2010-01-20 08:34 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-20 08:28:55 PST
Pretty much copied from SourceFrame + added corresponding TextEditor support.
Comment 1 Pavel Feldman 2010-01-20 08:34:31 PST
Created attachment 47037 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-01-20 11:06:16 PST
Comment on attachment 47037 [details]
[PATCH] Proposed change.

What does the "pack" in packAndRepaintAll mean?
Comment 3 Pavel Feldman 2010-01-25 03:01:45 PST
(In reply to comment #2)
> (From update of attachment 47037 [details])
> What does the "pack" in packAndRepaintAll mean?

Div decorations are managed by the text editor clients. Sometimes decoration affects line height and we need to invalidate line offsets. That's what pack is for. I think I'll come up with the better name in a follow up change.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/inspector/front-end/SourceFrame2.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
	A	WebCore/inspector/front-end/textEditor.css
Committed r53795