RESOLVED FIXED 33904
Web Inspector: Add support for addMessage/clearMessages to SourceFrame2. 
https://bugs.webkit.org/show_bug.cgi?id=33904
Summary Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
Pavel Feldman
Reported Wednesday, January 20, 2010 4:28:55 PM UTC
Pretty much copied from SourceFrame + added corresponding TextEditor support.
Attachments
[PATCH] Proposed change. (20.86 KB, patch)
2010-01-20 08:34 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 Wednesday, January 20, 2010 4:34:31 PM UTC
Created attachment 47037 [details] [PATCH] Proposed change.
Timothy Hatcher
Comment 2 Wednesday, January 20, 2010 7:06:16 PM UTC
Comment on attachment 47037 [details] [PATCH] Proposed change. What does the "pack" in packAndRepaintAll mean?
Pavel Feldman
Comment 3 Monday, January 25, 2010 11:01:45 AM UTC
(In reply to comment #2) > (From update of attachment 47037 [details]) > What does the "pack" in packAndRepaintAll mean? Div decorations are managed by the text editor clients. Sometimes decoration affects line height and we need to invalidate line offsets. That's what pack is for. I think I'll come up with the better name in a follow up change. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/inspector/front-end/SourceFrame2.js M WebCore/inspector/front-end/TextEditor.js M WebCore/inspector/front-end/TextEditorHighlighter.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/inspector.html A WebCore/inspector/front-end/textEditor.css Committed r53795
Note You need to log in before you can comment on or make changes to this bug.