Bug 33901 - [Android] Android lacks V8 version of JNIUtilityPrivate
Summary: [Android] Android lacks V8 version of JNIUtilityPrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 33843
Blocks: 32154
  Show dependency treegraph
 
Reported: 2010-01-20 07:13 PST by Steve Block
Modified: 2010-02-02 08:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (11.20 KB, patch)
2010-01-29 03:46 PST, Steve Block
ariya.hidayat: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-20 07:13:22 PST
The JSC-specific elements of WebCore/bridge/jni/JNIUtility were moved to WebCore/bridge/jni/jsc/JNIUtilityPrivate in http://trac.webkit.org/changeset/51756

Android requires a V8 version of this
Comment 1 Steve Block 2010-01-29 03:46:07 PST
Created attachment 47699 [details]
Patch
Comment 2 Ariya Hidayat 2010-02-01 07:48:41 PST
Comment on attachment 47699 [details]
Patch

LGTM.
Comment 3 Eric Seidel (no email) 2010-02-01 16:12:48 PST
Attachment 47699 [details] was posted by a committer and has review+, assigning to Steve Block for commit.
Comment 4 Steve Block 2010-02-01 16:19:06 PST
Comment on attachment 47699 [details]
Patch

Will land manually
Comment 5 Eric Seidel (no email) 2010-02-01 16:24:54 PST
Sorry about all the bug-spam to those of you using the commit queue.  I've filed bug 34456. about the problem.
Comment 6 Steve Block 2010-02-01 16:27:34 PST
Landed manually as http://trac.webkit.org/changeset/54171

Closing bug as resolved fixed.