RESOLVED FIXED 33900
media/video-play-pause-exception.html is flaky (on GTK at least) 
https://bugs.webkit.org/show_bug.cgi?id=33900
Summary media/video-play-pause-exception.html is flaky (on GTK at least)
Philippe Normand
Reported 2010-01-20 07:10:32 PST
In that test we try to play an empty <video> element. A timer is started after pause() has been called. I think it would be better to wait the pause event instead.
Attachments
Refactored the test to use the pause event instead of a timer. (2.54 KB, patch)
2010-01-20 07:12 PST, Philippe Normand 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-01-20 07:12:46 PST
Created attachment 47024 [details] Refactored the test to use the pause event instead of a timer.
Darin Adler
Comment 2 2010-01-20 08:29:44 PST
Comment on attachment 47024 [details] Refactored the test to use the pause event instead of a timer. > +<html> > +<body> This seems like a pointless change to me; including explicit HTML and body elements does not make our tests better. I assume it has no effect on the test. > + waitForEvent("pause", onpause); It seems to me we should call waitForEvent("pause") before calling video.play() and video.pause(). I would not have preserved the blank line at the end of the test created with consoleWrite. I would probably have used waitForEventTestAndEnd. Seems OK as is. r=me
Philippe Normand
Comment 3 2010-01-20 08:49:37 PST
Oh I didn't know about waitForEventTestAndEnd. Perfect fit for this test indeed ;)
Philippe Normand
Comment 4 2010-01-20 09:31:38 PST
Landed as r53550. Thanks for the review Darin!
Note You need to log in before you can comment on or make changes to this bug.