Bug 33898 - [Android] Android lacks V8 equivalent of JavaClassJSC
Summary: [Android] Android lacks V8 equivalent of JavaClassJSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks: 32154
  Show dependency tree / graph
 
Reported: 2010-01-20 06:28 PST by Steve Block
Modified: 2010-02-01 16:17 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.99 KB, patch)
2010-01-29 04:14 PST, Steve Block 		ariya.hidayat: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-20 06:28:03 PST 
The JSC-specific version of JavaClass was moved to JavaClassJSC in http://trac.webkit.org/changeset/53443 (ignore incorrect commit message)
Android requires a V8 version of JavaClass
Comment 1 Steve Block 2010-01-29 04:14:46 PST 
Created attachment 47703 [details]
Patch
Comment 2 Ariya Hidayat 2010-02-01 11:14:08 PST 
Comment on attachment 47703 [details]
Patch

LGTM.
Comment 3 Steve Block 2010-02-01 16:12:09 PST 
Comment on attachment 47703 [details]
Patch

cq- due to conflicts in Android.v8bindings.mk
Will land manually
Comment 4 Eric Seidel (no email) 2010-02-01 16:12:43 PST 
Attachment 47703 [details] was posted by a committer and has review+, assigning to Steve Block for commit.
Comment 5 Steve Block 2010-02-01 16:17:40 PST 
Landed manually as http://trac.webkit.org/changeset/54169

Closing bug as resolved fixed.