WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 33897
[Gtk] media/video-currentTime-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33897
Summary
[Gtk] media/video-currentTime-set.html is flaky
Philippe Normand
Reported
2010-01-20 05:53:00 PST
That test performs a seek then play() and wait 2 seconds for the ended event. On slow machines the media engine of the gtk port can take time to complete the seek. I think we should wait the end of the seek by waiting the "seeked" event and then fire the timer.
Attachments
Refactored the test to use the seeked event.
(3.06 KB, patch)
2010-01-20 05:55 PST
,
Philippe Normand
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2010-01-20 05:55:32 PST
Created
attachment 47013
[details]
Refactored the test to use the seeked event.
David Levin
Comment 2
2010-01-20 10:03:48 PST
fyi, typo in changelog: flacky
Eric Carlson
Comment 3
2010-01-20 10:11:27 PST
Comment on
attachment 47013
[details]
Refactored the test to use the seeked event. Nice change! r=me with David's suggested spelling fix
Philippe Normand
Comment 4
2010-01-21 00:38:39 PST
Landed as
r53612
. Thanks!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug