Bug 33897 - [Gtk] media/video-currentTime-set.html is flaky
Summary: [Gtk] media/video-currentTime-set.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-20 05:53 PST by Philippe Normand
Modified: 2010-01-21 00:38 PST (History)
1 user (show)

See Also:


Attachments
Refactored the test to use the seeked event. (3.06 KB, patch)
2010-01-20 05:55 PST, Philippe Normand
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-01-20 05:53:00 PST
That test performs a seek then play() and wait 2 seconds for the ended event. On slow machines the media engine of the gtk port can take time to complete the seek. I think we should wait the end of the seek by waiting the "seeked" event and then fire the timer.
Comment 1 Philippe Normand 2010-01-20 05:55:32 PST
Created attachment 47013 [details]
Refactored the test to use the seeked event.
Comment 2 David Levin 2010-01-20 10:03:48 PST
fyi, typo in changelog: flacky
Comment 3 Eric Carlson 2010-01-20 10:11:27 PST
Comment on attachment 47013 [details]
Refactored the test to use the seeked event.

Nice change!

r=me with David's suggested spelling fix
Comment 4 Philippe Normand 2010-01-21 00:38:39 PST
Landed as r53612. Thanks!