In HTMLMediaElement parseMappedAttribute() forwards autobuffer only if m_player has been created. m_player.setAutobuffer() should also be called just after the m_player has been created too (in loadResource()).
Created attachment 47032 [details] Forward autobuffer value to MediaPlayer instance.
Comment on attachment 47032 [details] Forward autobuffer value to MediaPlayer instance. Code change looks great. We normally require test cases or an explanation of why a test case is lacking. Since nobody is doing anything with the autobuffer flag right now, at least as far as I can tell with grep, I guess that's not possible here.
Well there is a test for autobuffer but it checks only the DOM attributes. After this patch I thought it would also be good for the MediaPlayer to call setAutobuffer() on its media engine after loading an url. Otherwise each media engine implementing setAutoBuffer() would need to manually call it. What do think? I am fine with sending an updated patch. BTW I need this for Bug 30004 ;)
Created attachment 47341 [details] updated patch
Comment on attachment 47341 [details] updated patch How do we test this? Looks sane, but all changes should have tests or explanation as to why testing is impossible.
(In reply to comment #5) > (From update of attachment 47341 [details]) > How do we test this? Looks sane, but all changes should have tests or > explanation as to why testing is impossible. Well I am still new to this but I didn't see unittests for the MediaPlayer, maybe it would make sense to have some? The MediaPlayerPrivate implementations are not unittested either, afaics. Anyway I landed this patch as r53910. I will think about unittesting the MediaPlayer at least.