Bug 33883 - Feature defines are difficult to maintain on Windows builds
Summary: Feature defines are difficult to maintain on Windows builds
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-19 23:05 PST by Steve Falkenburg
Modified: 2012-07-01 02:19 PDT (History)
1 user (show)

See Also:


Attachments
Patch (67.77 KB, patch)
2010-01-19 23:37 PST, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (26.06 KB, patch)
2012-06-27 00:23 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-01-19 23:05:42 PST
Feature defines are difficult to maintain on Windows builds
Comment 1 Steve Falkenburg 2010-01-19 23:37:57 PST
Created attachment 46984 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-01-20 08:19:27 PST
Comment on attachment 46984 [details]
Patch

It might be good to make the comment in FeatureDefines.vsprops a little more
explicit about how to add a new define (whether it is enabled or disabled).
I.e., you have to add it to the PreprocessorDefinitions, and also add a
UserMacro for it.

r=me
Comment 3 Steve Falkenburg 2010-01-20 09:52:21 PST
http://trac.webkit.org/changeset/53554
Comment 4 Charles Wei 2012-06-27 00:23:49 PDT
Reopening to attach new patch.
Comment 5 Charles Wei 2012-06-27 00:23:54 PDT
Created attachment 149696 [details]
Patch
Comment 6 Charles Wei 2012-07-01 02:18:48 PDT
Comment on attachment 149696 [details]
Patch

wrong place. This patch is for 88338 but put here by accident.
Comment 7 Charles Wei 2012-07-01 02:19:28 PDT
Mark it as invalid.