Bug 33881 - [Chromium] computePageRectsForFrame seems to be unnecessary
Summary: [Chromium] computePageRectsForFrame seems to be unnecessary
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-19 22:48 PST by Shinichiro Hamaji
Modified: 2010-01-20 00:26 PST (History)
2 users (show)

See Also:

Patch v1 (6.36 KB, patch)
2010-01-19 23:14 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-01-19 22:48:54 PST
It seems the pagination is done in PrintContext::computePageRects in WebCore/page/PrintContext is responsible for pagination on Chromium (note that this function is used in WebKit/chromium/src/WebFrameImpl.cpp via ChromePrintContext, which is a subclass of PrintContext). So, WebCore::computePageRectsForFrame in WebCore/page/FrameChromium.cpp, which is almost as same as PrintContext::computePageRects, would be unnecessary.
Comment 1 Shinichiro Hamaji 2010-01-19 23:14:13 PST
Created attachment 46981 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-01-20 00:26:38 PST
Comment on attachment 46981 [details]
Patch v1

Clearing flags on attachment: 46981

Committed r53527: <http://trac.webkit.org/changeset/53527>
Comment 3 Shinichiro Hamaji 2010-01-20 00:26:51 PST
All reviewed patches have been landed.  Closing bug.