Some resource loads are performed without going thru WebCore::ResourceHandle in Chrome. To associate those resource loads with the appropriate appcache, we need to get a ptr to the WebApplicationCacheHost given a WebFrame/WebDataSource.
Created attachment 46975 [details] WebDataSource::applicationCacheHost() getter
Attachment 46975 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebDataSourceImpl.cpp:112: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKit/chromium/src/ApplicationCacheHost.cpp:70: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKit/chromium/src/ApplicationCacheHost.cpp:265: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 46976 [details] fix style errors
Comment on attachment 46976 [details] fix style errors > Index: WebKit/chromium/public/WebApplicationCacheHost.h ... > +#if WEBKIT_IMPLEMENTATION > + static WebApplicationCacheHost* fromApplicationCacheHost(WebCore::ApplicationCacheHost*); > +#endif hmm... how about creating src/ApplicationCacheHostInternal.h, and then just expose toWebApplicationCacheHost from there? That way we won't need any implementation details added to the public header (albeit in a WEBKIT_IMPLEMENTATION section). otherwise, this lgtm.
> hmm... how about creating src/ApplicationCacheHostInternal.h, and then > just expose toWebApplicationCacheHost from there? That way we won't > need any implementation details added to the public header (albeit > in a WEBKIT_IMPLEMENTATION section). that sounds good > otherwise, this lgtm.
Created attachment 47054 [details] new .h file
ping
Comment on attachment 47054 [details] new .h file Clearing flags on attachment: 47054 Committed r53671: <http://trac.webkit.org/changeset/53671>
All reviewed patches have been landed. Closing bug.