Bug 33866 - Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
Summary: Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2010-01-19 13:57 PST by Laszlo Gombos
Modified: 2010-01-24 19:53 PST (History)
4 users (show)

See Also:


Attachments
proposed build fix for RVCT (2.57 KB, patch)
2010-01-19 14:31 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2010-01-19 13:57:21 PST
Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION macro. This I think makes the code a bit more readable as it is clear that DEFINE_STUB_FUNCTION(int, op_eq) is needed regardless of the USE(JSVALUE32_64) test.

This refactoring fixes a build break for the RVCT tool chain. For the RVCT toolchain (e.g. for Symbian) precompiler macros are not expanded before the code is passed to the assembler. This tool chain limitation and the corresponding workaround (simple perl script as pre-compiler) been documented as part of commit r52970.

The current perl script does not take all the C precompiler macros into account, so it expands the DEFINE_STUB_FUNCTION macro twice for DEFINE_STUB_FUNCTION(int, op_eq).
Comment 1 Laszlo Gombos 2010-01-19 14:31:23 PST
Created attachment 46953 [details]
proposed build fix for RVCT
Comment 2 Eric Seidel (no email) 2010-01-21 16:53:20 PST
Looks sane, but I'll CC the JIT people for a real review.
Comment 3 Maciej Stachowiak 2010-01-22 02:02:36 PST
Comment on attachment 46953 [details]
proposed build fix for RVCT

r=me
Comment 4 WebKit Commit Bot 2010-01-24 19:53:26 PST
Comment on attachment 46953 [details]
proposed build fix for RVCT

Clearing flags on attachment: 46953

Committed r53789: <http://trac.webkit.org/changeset/53789>
Comment 5 WebKit Commit Bot 2010-01-24 19:53:32 PST
All reviewed patches have been landed.  Closing bug.