Bug 33854 - Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns more info about where the result was found
Summary: Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Enhancement
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-19 11:40 PST by John Sullivan
Modified: 2010-01-19 20:09 PST (History)
2 users (show)

See Also:


Attachments
Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters (24.68 KB, patch)
2010-01-19 13:24 PST, John Sullivan
no flags Details | Formatted Diff | Diff
Revised patch that replaces line-ending "( "s with "(" to make style checking script happy. (33.63 KB, patch)
2010-01-19 13:33 PST, John Sullivan
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2010-01-19 11:40:39 PST
WebHTMLRepresentation's searchForLabelsBeforeElement SPI function is used to search in the HTML visible content for any string from a given set of strings. It uses some heuristics for computing the result, but does not return any information about how the result was computed. It would be useful to clients of this function if they knew more about how the result was computed, in order to apply higher-level heuristics.
Comment 1 John Sullivan 2010-01-19 13:24:31 PST
Created attachment 46943 [details]
Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters
Comment 2 WebKit Review Bot 2010-01-19 13:25:44 PST
Attachment 46943 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebHTMLRepresentation.cpp:199:  Extra space after ( in function call  [whitespace/parens] [4]
WebKit/win/WebHTMLRepresentation.h:93:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 2


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 John Sullivan 2010-01-19 13:33:02 PST
Created attachment 46944 [details]
Revised patch that replaces line-ending "( "s with "(" to make style checking script happy.
Comment 4 John Sullivan 2010-01-19 15:26:16 PST
Committed r53500: <http://trac.webkit.org/changeset/53500>
Comment 5 Eric Seidel (no email) 2010-01-19 16:28:35 PST
This broke the Tiger build:
http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/7925/steps/compile-webkit/logs/stdio
Comment 6 John Sullivan 2010-01-19 20:09:35 PST
Fixed Tiger build in r53519.