Bug 33853 - InspectorTimelineAgent refactor to support reporting data when closing a record
Summary: InspectorTimelineAgent refactor to support reporting data when closing a record
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-19 11:35 PST by jaimeyap
Modified: 2010-01-19 13:49 PST (History)
4 users (show)

See Also:


Attachments
InspectorTimelineAgent refactor to support reporting data when closing a record (26.80 KB, patch)
2010-01-19 11:49 PST, jaimeyap
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jaimeyap 2010-01-19 11:35:43 PST
This patch (soon to be attached) refactors the TimelineRecordFactory and InspectorTimelineAgent to support reporting data when closing a record. Since ScriptObject has no get method for retrieving fields, eagerly installing a data object on the base record precluded us from adding any fields to it later on.

This patch also includes grabbing the start and end line number for parse HTML records as a reference use case for the above refactor.
Comment 1 jaimeyap 2010-01-19 11:49:59 PST
Created attachment 46932 [details]
InspectorTimelineAgent refactor to support reporting data when closing a record
Comment 2 WebKit Commit Bot 2010-01-19 13:49:38 PST
Comment on attachment 46932 [details]
InspectorTimelineAgent refactor to support reporting data when closing a record

Clearing flags on attachment: 46932

Committed r53488: <http://trac.webkit.org/changeset/53488>
Comment 3 WebKit Commit Bot 2010-01-19 13:49:45 PST
All reviewed patches have been landed.  Closing bug.