RESOLVED FIXED 33829
Web Inspector: Timeline panel's reset button problem 
https://bugs.webkit.org/show_bug.cgi?id=33829
Summary Web Inspector: Timeline panel's reset button problem
Ilya Tikhonovsky
Reported 2010-01-18 23:52:30 PST
Timeline reset button doesn't clean timeline if the panel is scrolled down. The overview pane also stay unmodified after reset.
Attachments
The fix for reset button at Timeline panel (2.93 KB, patch)
2010-01-19 02:02 PST, Ilya Tikhonovsky 		pfeldman: review-
DetailsFormatted DiffDiff
The fix for reset button at Timeline panel (3.60 KB, patch)
2010-01-20 06:30 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
The fix for reset button at Timeline panel (4.11 KB, patch)
2010-01-20 07:41 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
The fix for reset button at Timeline panel (3.73 KB, patch)
2010-01-20 08:10 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-01-19 02:02:57 PST
Created attachment 46897 [details] The fix for reset button at Timeline panel Fixes for: Texts for dividers at overview pane; Reset button functionality when Timeline was scrolled down; Reset button functionality when working window has been changed; Scroll position calculation when Timeline was scrolled down and working window was adjusted by overview pane.
Pavel Feldman
Comment 2 2010-01-19 02:39:00 PST
Comment on attachment 46897 [details] The fix for reset button at Timeline panel > + if (recordsInWindow.length > startIndex) > + while (startIndex > 0 && recordsInWindow[startIndex].parent) > + startIndex--; > + else > + startIndex = recordsInWindow.length ? recordsInWindow.length - 1 : 0; > + I think that what has been happening here was fundamentally wrong. It probably regressed when I introduced expansion/collapsing. Row offset can no longer be calculated as number of record * row height. We now need to take expanded state into consideration.
Ilya Tikhonovsky
Comment 3 2010-01-20 06:30:14 PST
Created attachment 47017 [details] The fix for reset button at Timeline panel The fix for reset button at Timeline panel. Fixes for: Texts for dividers at overview pane; Reset button functionality when Timeline was scrolled down; Reset button functionality when working window has been changed; Scroll position calculation when Timeline ±was scrolled down and working window was adjusted by overview pane. Obsolete adjustment of startIndex was removed.
Ilya Tikhonovsky
Comment 4 2010-01-20 07:41:52 PST
Created attachment 47031 [details] The fix for reset button at Timeline panel The fix for reset button at Timeline panel. Fixes for: Texts for dividers at overview pane; Reset button functionality when Timeline was scrolled down; Reset button functionality when working window has been changed; Scroll position calculation when Timeline was scrolled down and working window was adjusted by overview pane.
Ilya Tikhonovsky
Comment 5 2010-01-20 08:10:34 PST
Created attachment 47036 [details] The fix for reset button at Timeline panel The fix for reset button at Timeline panel Fixes for: Texts for dividers at overview pane; Reset button functionality when Timeline was scrolled down; Reset button functionality when working window has been changed; Scroll position calculation when Timeline was scrolled down and working window was adjusted by overview pane.
WebKit Commit Bot
Comment 6 2010-01-20 18:08:26 PST
Comment on attachment 47036 [details] The fix for reset button at Timeline panel Clearing flags on attachment: 47036 Committed r53588: <http://trac.webkit.org/changeset/53588>
WebKit Commit Bot
Comment 7 2010-01-20 18:08:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.