Bug 33820 - Inline functions that are hot in DOM manipulation
Summary: Inline functions that are hot in DOM manipulation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-18 17:52 PST by Maciej Stachowiak
Modified: 2010-01-19 23:34 PST (History)
1 user (show)

See Also:

Attachments
Patch (27.91 KB, patch)
2010-01-18 18:14 PST, Maciej Stachowiak 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2010-01-18 17:52:04 PST 
Inline functions that are hot in DOM manipulation
Comment 1 Maciej Stachowiak 2010-01-18 18:14:46 PST 
Created attachment 46873 [details]
Patch
Comment 2 Adam Barth 2010-01-18 18:17:03 PST 
Comment on attachment 46873 [details]
Patch

I approve this product and/or service.
Comment 3 Darin Adler 2010-01-19 09:04:06 PST 
Comment on attachment 46873 [details]
Patch

> -    Document(Frame*, bool isXHTML);
> +    Document(Frame*, bool isXHTML, bool isHTML);

I'd much rather see an enum here instead of two bools.
Comment 4 Maciej Stachowiak 2010-01-19 18:25:40 PST 
Committed r53514: <http://trac.webkit.org/changeset/53514>
Comment 5 Eric Seidel (no email) 2010-01-19 23:34:09 PST 
A webgl failure seemed to start with this checkin:
http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r53517%20(9580)/fast/canvas/webgl/texImage2DImageDataTest-pretty-diff.html

The first failure started between r53514 and r53517 inclusive.