Bug 33813 - Crash when using DOMApplicationCache from a destroyed frame
Summary: Crash when using DOMApplicationCache from a destroyed frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on: 33811
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-18 14:26 PST by Alexey Proskuryakov
Modified: 2010-01-18 14:52 PST (History)
0 users

See Also:

Attachments
proposed fix (4.22 KB, patch)
2010-01-18 14:39 PST, Alexey Proskuryakov 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-01-18 14:26:27 PST 
DOMApplicationCache::scriptExecutionContext() isn't prepared have its frame destroyed.

<rdar://problem/7545104>
Comment 1 Alexey Proskuryakov 2010-01-18 14:39:27 PST 
Created attachment 46852 [details]
proposed fix
Comment 2 Geoffrey Garen 2010-01-18 14:45:35 PST 
Comment on attachment 46852 [details]
proposed fix

r=me

I think you need a follow-up patch to fix callers of scriptExecutionContext() so they all check for null, though.
Comment 3 Alexey Proskuryakov 2010-01-18 14:52:16 PST 
Committed <http://trac.webkit.org/changeset/53433>.