Bug 33794 - Web Inspector: Speed-up Timeline panel scrolling (second iteration).
Summary: Web Inspector: Speed-up Timeline panel scrolling (second iteration).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-18 05:15 PST by Ilya Tikhonovsky
Modified: 2010-01-18 10:31 PST (History)
2 users (show)

See Also:


Attachments
The fixes for Timeline panel scrolling speed (6.09 KB, patch)
2010-01-18 06:12 PST, Ilya Tikhonovsky
pfeldman: review-
Details | Formatted Diff | Diff
Next iteration. Calculator object was a bit redesigned. (7.50 KB, patch)
2010-01-18 07:45 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-01-18 05:15:24 PST
Timeline's panel scrolling speed can be 2 times faster.
Comment 1 Ilya Tikhonovsky 2010-01-18 06:12:25 PST
Created attachment 46814 [details]
The fixes for Timeline panel scrolling speed
Comment 2 Pavel Feldman 2010-01-18 06:31:17 PST
Comment on attachment 46814 [details]
The fixes for Timeline panel scrolling speed

> +    this._graphRows = document.createElement("div");

We typically call elements someElement. Maybe kill it?

> -        var start = (record.startTime - this.minimumBoundary) / this.boundarySpan * 100;
> -        var end = (record.endTime - this.minimumBoundary) / this.boundarySpan * 100;
> +        var start = (record.startTime - this._context.minB) / this._context.bSpan * 100;

this._context.minimumBoundary. Btw, this calculator is supposed to cache min and max boundaries, so it is not clear why you are gaining some win out of it. Maybe cache is broken? Or typeof ... === "number" works slowly? Should we try using -1 as an uninitialized value then?
Comment 3 Ilya Tikhonovsky 2010-01-18 07:45:59 PST
Created attachment 46824 [details]
Next iteration. Calculator object was a bit redesigned.
Comment 4 WebKit Commit Bot 2010-01-18 10:31:30 PST
Comment on attachment 46824 [details]
Next iteration. Calculator object was a bit redesigned.

Clearing flags on attachment: 46824

Committed r53413: <http://trac.webkit.org/changeset/53413>
Comment 5 WebKit Commit Bot 2010-01-18 10:31:42 PST
All reviewed patches have been landed.  Closing bug.