Bug 33787 - Add constants for more XML strings
Summary: Add constants for more XML strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-18 01:16 PST by Alexey Proskuryakov
Modified: 2010-01-18 14:06 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (25.10 KB, patch)
2010-01-18 01:39 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-01-18 01:16:21 PST
From bug 33752:

I suggest we add the strings "xmlns", "http://www.w3.org/2000/xmlns/", and
"xml" all to XMLNames.h alongside xmlNamespaceURI and use named constants
instead of literal strings.
Comment 1 Alexey Proskuryakov 2010-01-18 01:39:10 PST
Created attachment 46803 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-01-18 01:46:50 PST
Attachment 46803 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/dom/Node.cpp:1868:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/dom/Node.cpp:1923:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 2


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2010-01-18 02:11:10 PST
Attachment 46803 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/195756
Comment 4 Alexey Proskuryakov 2010-01-18 08:27:21 PST
> Build output: http://webkit-commit-queue.appspot.com/results/195756

It's empty.
Comment 5 Alexey Proskuryakov 2010-01-18 14:06:51 PST
Committed revision 53429.