Bug 33780 – Build WebKitGtk on OpenSolaris with Sun Studio 12 using apache STL(stdcxx4)

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKitGTK

[Simon]

STL library(Cstd) come with SS12 is too out for WTF and STLport come with SS12 is not SUN recommend. 
Since apache STL(stdcxx4) is been integrated in OpenSolaris since nv124,i manage to build WebKitGtk on OpenSolaris successfully with some patches, those patch also work on linux with gcc.
those patches are based on webkitgtk 1.1.17 release.

Also noticed some work has been done in webkitgt on Solaris 10 with SS12
24932:WebKit compilation support in Solaris 10 with Sun Studio 12 (CC 5.9)

[Simon]

Created attachment 46777 [details]
add sun cc support in WFT

"./JavaScriptCore/wtf/Vector.h", line 48: Error: #error WTF_ALIGN macros need alignment control..
make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1
make[1]: Leaving directory `/export/home/simon/webkitwork/17work/webkit-1.1.17

[Simon]

Created attachment 46778 [details]
explicit KURL to Sting

"./WebCore/loader/DocumentLoader.h", line 166: Error: Different types for "?:" (WebCore::String and WebCore::KURL).
./WebCore/platform/network/ResourceHandleInternal.h", line 50: Error: The name Frame is ambiguous, Frame and WebCore::Frame.

[Simon]

Created attachment 46779 [details]
delete illegal option for SUN CC

cc: illegal option -Wall
delete illegal option for SUN CC

[Simon]

Created attachment 46780 [details]
Add Solaris platform support

add Solaris platform support

[Simon]

Created attachment 46781 [details]
support-stdcxx4 instead of Cstd that come with SS12

it's actually better use solaris_use_no-cstd instead of solaris_use_stlport4 here.;

[Simon]

Created attachment 46782 [details]
explicit const char* in SVG

[Alexey Proskuryakov]

This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information.

I don't see it explained why these type casts are needed. Anyway, WebKit coding style is to use C++ style casts, so (const char *) isn't OK.