Bug 33757 - Reduce duplication in run-webkit-httpd and run-webkit-tests
Summary: Reduce duplication in run-webkit-httpd and run-webkit-tests
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-15 22:10 PST by Holger Freyther
Modified: 2010-02-03 05:39 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.74 KB, patch)
2010-01-15 22:10 PST, Holger Freyther
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2010-01-15 22:10:16 PST
Created attachment 46737 [details]
Patch

Currently both scripts have code to figure out the name of the apache2
executable and which configuration file to use for the server. I'm currently
in the process of making run-iexploder-tests work for everyone else and
would have to copy the code again.
Instead of copying it to the iexploder-tests script I'm copying it to
webkitdirs.pm and make both existing scripts use the new method to
figure out httpdPath and httpdConfiguration.
Comment 1 Darin Adler 2010-01-16 11:50:37 PST
Comment on attachment 46737 [details]
Patch

I don't feel great about this -- the webktidirs.pm file is getting bigger and bigger with no clear concept of what it does and does not do!

r=me
Comment 2 Holger Freyther 2010-01-16 21:34:46 PST
(In reply to comment #1)
> (From update of attachment 46737 [details])
> I don't feel great about this -- the webktidirs.pm file is getting bigger and
> bigger with no clear concept of what it does and does not do!

Well, then let us get the concept? Should I write to webkit-dev about it? I think python vs. perl is also playing a role here?
Comment 3 Eric Seidel (no email) 2010-02-01 16:12:18 PST
Attachment 46737 [details] was posted by a committer and has review+, assigning to Holger Freyther for commit.
Comment 4 Alexey Proskuryakov 2010-02-02 12:15:56 PST
We also have WebKitTools/Scripts/webkitperl/httpd.pm now - could it be a better place to move this code to?
Comment 5 Holger Freyther 2010-02-03 05:39:08 PST
(In reply to comment #4)
> We also have WebKitTools/Scripts/webkitperl/httpd.pm now - could it be a better
> place to move this code to?

I think most of this is deprecated anyway. I will close this now and come up with a patch for run-iexploder-tests.