Bug 33745 - Split out "prepare-rollout" from "rollout" and make --complete-rollout default
Summary: Split out "prepare-rollout" from "rollout" and make --complete-rollout default
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-15 14:36 PST by Eric Seidel (no email)
Modified: 2010-02-19 15:07 PST (History)
2 users (show)

See Also:

Patch (14.77 KB, patch)
2010-01-26 06:58 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-15 14:36:40 PST
Split out "prepare-rollout" and "land-rollout" from "rollout" and make --complete-rollout default

--complete-rollout was a hack back when I didn't trust rollout.  It's still possible for it to go wrong, but unlikely.   Especially with our diff-confirmation step, we should remove the --complete-rollout flag.

It's sometimes useful to be able to prepare rollouts and land them after further editing.  prepare-rollout would be useful.  Which woudl effectively be the current "rollout" without --complete-rollout passed.
Comment 1 Adam Barth 2010-01-15 22:33:18 PST
I think this patch is super easy.  You should just do it.
Comment 2 Eric Seidel (no email) 2010-01-26 06:53:31 PST
Haven't written "land-rollout" yet (because it requires some fancy reason parsing from the ChangeLog), but the rest is done.  Will upload.
Comment 3 Eric Seidel (no email) 2010-01-26 06:58:00 PST
Created attachment 47408 [details]
Comment 4 Adam Barth 2010-02-19 14:21:41 PST
Comment on attachment 47408 [details]

Excellent!  I think you can get rid of MetaStep now, btw.
Comment 5 Eric Seidel (no email) 2010-02-19 14:28:12 PST
I expect the cq+ will fail, but if it doesn't it saves me time landing! :)
Comment 6 WebKit Commit Bot 2010-02-19 15:07:07 PST
Comment on attachment 47408 [details]

Clearing flags on attachment: 47408

Committed r55034: <http://trac.webkit.org/changeset/55034>
Comment 7 WebKit Commit Bot 2010-02-19 15:07:12 PST
All reviewed patches have been landed.  Closing bug.