RESOLVED FIXED 33745
Split out "prepare-rollout" from "rollout" and make --complete-rollout default 
https://bugs.webkit.org/show_bug.cgi?id=33745
Summary Split out "prepare-rollout" from "rollout" and make --complete-rollout default
Eric Seidel (no email)
Reported 2010-01-15 14:36:40 PST
Split out "prepare-rollout" and "land-rollout" from "rollout" and make --complete-rollout default --complete-rollout was a hack back when I didn't trust rollout. It's still possible for it to go wrong, but unlikely. Especially with our diff-confirmation step, we should remove the --complete-rollout flag. It's sometimes useful to be able to prepare rollouts and land them after further editing. prepare-rollout would be useful. Which woudl effectively be the current "rollout" without --complete-rollout passed.
Attachments
Patch (14.77 KB, patch)
2010-01-26 06:58 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-15 22:33:18 PST
I think this patch is super easy. You should just do it.
Eric Seidel (no email)
Comment 2 2010-01-26 06:53:31 PST
Haven't written "land-rollout" yet (because it requires some fancy reason parsing from the ChangeLog), but the rest is done. Will upload.
Eric Seidel (no email)
Comment 3 2010-01-26 06:58:00 PST
Created attachment 47408 [details] Patch
Adam Barth
Comment 4 2010-02-19 14:21:41 PST
Comment on attachment 47408 [details] Patch Excellent! I think you can get rid of MetaStep now, btw.
Eric Seidel (no email)
Comment 5 2010-02-19 14:28:12 PST
I expect the cq+ will fail, but if it doesn't it saves me time landing! :)
WebKit Commit Bot
Comment 6 2010-02-19 15:07:07 PST
Comment on attachment 47408 [details] Patch Clearing flags on attachment: 47408 Committed r55034: <http://trac.webkit.org/changeset/55034>
WebKit Commit Bot
Comment 7 2010-02-19 15:07:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.