Bug 33744 – video.networkState remains NETWORK_LOADING indefinitely when no <source> element was able to be loaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Adam Roben (:aroben)]

To reproduce:

1. Download the attached test case to LayoutTests/media
2. run-webkit-tests media/media-no-source-networkState.html

The test fails because video.networkState has remained NETWORK_LOADING even though we failed to load the one and only <source> element.

HTML5 says networkState should be NETWORK_NO_SOURCE at this point. See <http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html#concept-media-load-algorithm> step 6.17:

> ⌛ Waiting: Set the element's networkState attribute to the NETWORK_NO_SOURCE value.

Note that <video src=doesnotexist.mp4> does not have this bug.

[Adam Roben (:aroben)]

<rdar://problem/7547644>

[Adam Roben (:aroben)]

I think we need to set m_networkState here <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLMediaElement.cpp?rev=53146#L692>:

        // If we failed while trying to load a <source> element, the movie was never parsed, and there are more
        // <source> children, schedule the next one
        if (m_readyState < HAVE_METADATA && m_loadState == LoadingFromSourceElement) {
            m_currentSourceNode->scheduleErrorEvent();
            if (havePotentialSourceChild())
                scheduleNextSourceChild();
            return;
        }

[Adam Roben (:aroben)]

This seems related to bug 33735.

[Eric Carlson]

Looks like you forgot to attach the test case.

[Adam Roben (:aroben)]

Created attachment 46817 [details]
test case

(I think there's something buggy with adding an attachment to a bug that you are just creating (i.e., using the "Add Attachment" form on the Create Bug page).)

[Eric Carlson]

Created attachment 46921 [details]
Proposed patch

[Adam Roben (:aroben)]

Comment on attachment 46921 [details]
Proposed patch

Your test seems to indicate that this fixes bug 33735, too. Is that true?

r=me

[Eric Carlson]

http://trac.webkit.org/changeset/53478