Bug 33739 – Fullscreen video HUD stays on top when switching to another window (e.g. via Alt-Tab)

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Adam Roben (:aroben)]

To reproduce:

1. Go to a page with <video controls>
2. Click the fullscreen button in the video's controls
3. Switch to another window via Alt-Tab (e.g., the Safari window that contained the <video>)

The fullscreen video's HUD stays on screen, on top of whatever window you've just switched to.

[Adam Roben (:aroben)]

<rdar://problem/7547574>

[Beth Dakin]

Created attachment 50556 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 50556 [details]
Patch

>  void FullscreenVideoController::draw()
>  {
> +    HWND foregroundWindow = GetForegroundWindow();
> +    if (foregroundWindow == m_videoWindow)
> +        createHUDWindow();
> +    else if (foregroundWindow != m_hudWindow)
> +        destroyHUDWindow();
> +

After this, I think you should assert that m_hudWindow is non-null. And maybe you should bail if it is null, in release builds.

r=me

[Beth Dakin]

Created attachment 50631 [details]
New patch

Adam and I discussed a better way to do this on IRC!

[Adam Roben (:aroben)]

Comment on attachment 50631 [details]
New patch

r=me!

[Beth Dakin]

Fixed with r55942.