Bug 33728 - svg/custom/marker-changes.svg is flaky
Summary: svg/custom/marker-changes.svg is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-15 11:48 PST by Ojan Vafai
Modified: 2010-01-15 12:20 PST (History)
0 users

See Also:

Attachments
Patch (2.01 KB, patch)
2010-01-15 11:49 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (1.97 KB, patch)
2010-01-15 12:03 PST, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-01-15 11:48:47 PST 
svg/custom/marker-changes.svg is flaky
Comment 1 Ojan Vafai 2010-01-15 11:49:47 PST 
Created attachment 46694 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-01-15 11:55:12 PST 
Comment on attachment 46694 [details]
Patch

But your'e not removing the setTimeout?  You're just moving it... no?  I'm confused why this test needs one at all.
Comment 3 Ojan Vafai 2010-01-15 12:03:37 PST 
Created attachment 46695 [details]
Patch
Comment 4 Ojan Vafai 2010-01-15 12:04:32 PST 
(In reply to comment #2)
> (From update of attachment 46694 [details])
> But your'e not removing the setTimeout?  You're just moving it... no?  I'm
> confused why this test needs one at all.

Duh. I was just focused on the race. Removed the setTimeout for real this time and no longer needing to waitUntilDone.
Comment 5 Eric Seidel (no email) 2010-01-15 12:06:30 PST 
Comment on attachment 46695 [details]
Patch

Assuming it still passes, LGTM.
Comment 6 Ojan Vafai 2010-01-15 12:20:23 PST 
Committed r53337: <http://trac.webkit.org/changeset/53337>