WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33728
svg/custom/marker-changes.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=33728
Summary
svg/custom/marker-changes.svg is flaky
Ojan Vafai
Reported
2010-01-15 11:48:47 PST
svg/custom/marker-changes.svg is flaky
Attachments
Patch
(2.01 KB, patch)
2010-01-15 11:49 PST
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Patch
(1.97 KB, patch)
2010-01-15 12:03 PST
,
Ojan Vafai
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2010-01-15 11:49:47 PST
Created
attachment 46694
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-01-15 11:55:12 PST
Comment on
attachment 46694
[details]
Patch But your'e not removing the setTimeout? You're just moving it... no? I'm confused why this test needs one at all.
Ojan Vafai
Comment 3
2010-01-15 12:03:37 PST
Created
attachment 46695
[details]
Patch
Ojan Vafai
Comment 4
2010-01-15 12:04:32 PST
(In reply to
comment #2
)
> (From update of
attachment 46694
[details]
) > But your'e not removing the setTimeout? You're just moving it... no? I'm > confused why this test needs one at all.
Duh. I was just focused on the race. Removed the setTimeout for real this time and no longer needing to waitUntilDone.
Eric Seidel (no email)
Comment 5
2010-01-15 12:06:30 PST
Comment on
attachment 46695
[details]
Patch Assuming it still passes, LGTM.
Ojan Vafai
Comment 6
2010-01-15 12:20:23 PST
Committed
r53337
: <
http://trac.webkit.org/changeset/53337
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug