RESOLVED INVALID 33727
'make dist' misses some files in the nightly build 
https://bugs.webkit.org/show_bug.cgi?id=33727
Summary 'make dist' misses some files in the nightly build
Danilo Šegan
Reported 2010-01-15 11:27:43 PST
I tried building webkit r53331 from svn (as a package for Ubuntu) and ran into several files missing from 'make dist'. I'll attach a full patch once webkit finishes building, but here's what I found missing so far: --- WebCore/GNUmakefile.am (revision 53331) + WebCore/html/canvas/CanvasContextAttributes.h \ + WebCore/platform/graphics/GraphicsLayer.h \ + WebCore/platform/graphics/TypesettingFeatures.h \ + WebCore/plugins/PluginWidget.h \ FWIW, I've also hit http://www.mail-archive.com/bug-autoconf@gnu.org/msg02270.html but I am solving that with a modified "mydist" rule along the lines of +dist.txt: + FILES_TO_DIST=$(words $(DISTFILES)) + echo "$(wordlist 1,2000,$(DISTFILES))" > dist.txt + echo "$(wordlist 2001,4000,$(DISTFILES))" >> dist.txt
Attachments
First .h files missing from dist rules (1.42 KB, patch)
2010-01-15 11:32 PST, Danilo Šegan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Danilo Šegan
Comment 1 2010-01-15 11:32:34 PST
Created attachment 46693 [details] First .h files missing from dist rules I will "override" this patch if I find more instances.
Danilo Šegan
Comment 2 2010-01-15 12:20:46 PST
Ok, this are all I have found missing, so the above patch should be complete.
Alexey Proskuryakov
Comment 3 2010-06-12 16:29:58 PDT
This patch has been overlooked, because it isn't marked for review. Please see <http://webkit.org/coding/contributing.html> for more information.
Martin Robinson
Comment 4 2014-03-25 15:32:10 PDT
This was probably fixed long ago and 'make dist' has totally changed with the new build system.
Note You need to log in before you can comment on or make changes to this bug.