Bug 3372 – JavaScriptCore/kjs/date_object on win32

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Justin Haygood]

date_object doesn't build on Win32

--Unsupported Features

[Justin Haygood]

Created attachment 2163 [details]
Patches to build on Win32

Fixes date_object on Win32

[Justin Haygood]

Created attachment 2164 [details]
Additional Files

Contains wincommon.h, wintime.cpp, wintime.h

Windows specific date/time implementations used by date_object
Windows specific common defines used by date_object

[Justin Haygood]

Created attachment 2165 [details]
Ooops.. New Patch

Ooops, new patch. Old one had some temporary stuff and some useless stuff.
Fixed now!

[Justin Haygood]

Created attachment 2232 [details]
Test Date for testkjs

Test date usage in JavaScript for testkjs.

It outputs the current time as HH:MM:SS:MS

Its currently 7:14 PM, and it gives the following output:

C:\Documents and Settings\Justin Haygood\My Documents\Visual Studio
2005\Project
s\WebKit-Win32\test_kjs\Debug>test_kjs testdate.js
--> 19:13:2:125
OK.

So, i believe this patch works :-D

[Justin Haygood]

(In reply to comment #4)
> Created an attachment (id=2232) [edit]
> Test Date for testkjs
> 
> Test date usage in JavaScript for testkjs.
> 
> It outputs the current time as HH:MM:SS:MS
> 
> Its currently 7:14 PM, and it gives the following output:
> 
> C:\Documents and Settings\Justin Haygood\My Documents\Visual Studio
> 2005\Project
> s\WebKit-Win32\test_kjs\Debug>test_kjs testdate.js
> --> 19:13:2:125
> OK.
> 
> So, i believe this patch works :-D
> 


Er, I meant its 7:16 and gives the following output:
C:\Documents and Settings\Justin Haygood\My Documents\Visual Studio 2005\Project
s\WebKit-Win32\test_kjs\Debug>test_kjs testdate.js
--> 19:16:21:968
OK.

[Harri Porten]

FWIW: the KDE version of date_object.cpp compiles on Windows just fine. No need
for additional files/functions to be added. At most some #ifdef correction is
needed.

[Darin Adler]

Sounds like it might be better to take the KDE date_object.cpp.

[Justin Haygood]

(In reply to comment #7)
> Sounds like it might be better to take the KDE date_object.cpp.

I might actually do that, but that'll be one heck of a diff :-D. I'll just 
attach it instead of a diff. Is it possible to completely replace a file in 
CVS? Also, a few changes might have to be done, as KJS prefixes everything 
with KJS_EXPORT but JavaScriptCore does not, and KJS_EXPORT isn't needed in my 
builds, since I use it statically. I'll be busy for the next 2 weeks, mainly 
personal projects and the national SkillUSA competition, so it might be a 
while before I get to it.

[Darin Adler]

We may not want to completely overwrite our file with the KDE one. For example, we want to use the locale 
data and time implementation in our file.

It's best to attach a diff, even if it's large.

[Darin Adler]

Comment on attachment 2165 [details]
Ooops.. New Patch

See bug 3477 for what looks like a promising patch.

I'm rejecting this patch because I'd prefer to take KDE changes to compile on
Windows rather than doing changes of our own.

[Justin Haygood]

Created attachment 2722 [details]
Hopefully this works!

1. KJS date_object.cpp base
2. includes Apple specific #if APPLE_CHANGES
3. very small #ifdef for Win32... very very small

[Justin Haygood]

No longer applies.