Bug 33709 – Cleanup: Typedef DragOperation as type int

• Status: NEW
• Component: WebCore Misc.

[Daniel Bates]

Following up on a remark brought up by Eric Seidel <https://bugs.webkit.org/show_bug.cgi?id=24731#c25>, we should typedef DragOperation as type int since it is also used to compose bitwise masks of multiple drag operations.

Use of DragOperation as a bitwise mask appears in:

Clipboard.cpp:

<http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L71>
<http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L73>
<http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L75>
<http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L83>

DragController.cpp:

<http://trac.webkit.org/browser/trunk/WebCore/page/DragController.cpp?rev=53296#L639>

[Daniel Bates]

Created attachment 46660 [details]
Patch

No functionality was changed. So, no new tests.

[Oliver Hunt]

Comment on attachment 46660 [details]
Patch

I suspect this will break windows due to missing window export file updates

[Eric Seidel (no email)]

Attachment 46660 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/189110

[Daniel Bates]

Comment on attachment 46660 [details]
Patch

Clearing review flag, while I look into this. There seems to be signed/unsigned mismatching issues.

[Adam Roben (:aroben)]

I think it would be better to leave DragOperation as an enum, but introduce a new DragOperationMask typedef (we normally use unsigned for this). Then we'd use DragOperationMask everywhere that multiple DragOperations are combined.