Bug 33705 - UStringImpl::create() should use internal storage
Summary: UStringImpl::create() should use internal storage
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2010-01-14 23:35 PST by Gavin Barraclough
Modified: 2010-01-14 23:48 PST (History)
0 users

See Also:

The patch (3.77 KB, patch)
2010-01-14 23:37 PST, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-01-14 23:35:55 PST
When creating a UStringImpl copying of a UChar*, we can use an internal buffer, by calling UStringImpl::tryCreateUninitialized().
Comment 1 Gavin Barraclough 2010-01-14 23:37:40 PST
Created attachment 46644 [details]
The patch

~0.5% progression on SunSpider
Comment 2 Oliver Hunt 2010-01-14 23:40:41 PST
Comment on attachment 46644 [details]
The patch

r=me, you should remove "Need a short description and bug URL (OOPS!)" from the changelog however :)
Comment 3 Gavin Barraclough 2010-01-14 23:48:19 PST
Committed revision 53323.