WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33705
UStringImpl::create() should use internal storage
https://bugs.webkit.org/show_bug.cgi?id=33705
Summary
UStringImpl::create() should use internal storage
Gavin Barraclough
Reported
2010-01-14 23:35:55 PST
When creating a UStringImpl copying of a UChar*, we can use an internal buffer, by calling UStringImpl::tryCreateUninitialized().
Attachments
The patch
(3.77 KB, patch)
2010-01-14 23:37 PST
,
Gavin Barraclough
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-01-14 23:37:40 PST
Created
attachment 46644
[details]
The patch ~0.5% progression on SunSpider
Oliver Hunt
Comment 2
2010-01-14 23:40:41 PST
Comment on
attachment 46644
[details]
The patch r=me, you should remove "Need a short description and bug URL (OOPS!)" from the changelog however :)
Gavin Barraclough
Comment 3
2010-01-14 23:48:19 PST
Committed revision 53323.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug